Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carbon Period functionality #78

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Add Carbon Period functionality #78

merged 2 commits into from
Apr 28, 2022

Conversation

gmhafiz
Copy link
Contributor

@gmhafiz gmhafiz commented Apr 25, 2022

Adds a simple Carbon Period functionality https://carbon.nesbot.com/docs/#api-period that only accepts

  1. Start date
  2. period in days
  3. End date

It returns an array of Carbon.

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #78 (8ab69d8) into master (ce063dd) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   89.11%   89.39%   +0.27%     
==========================================
  Files           3        4       +1     
  Lines         634      641       +7     
==========================================
+ Hits          565      573       +8     
  Misses         44       44              
+ Partials       25       24       -1     
Impacted Files Coverage Δ
carbon.go 90.21% <100.00%> (-0.25%) ⬇️
carbonPeriod.go 100.00% <100.00%> (ø)
translator.go 65.51% <100.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bcf706...8ab69d8. Read the comment docs.

@gmhafiz
Copy link
Contributor Author

gmhafiz commented Apr 28, 2022

I can definitely cover the two lines not covered by unit test

carbonPeriod.go Outdated Show resolved Hide resolved
@rntdrts
Copy link
Contributor

rntdrts commented Apr 28, 2022

I can definitely cover the two lines not covered by unit test

Thank you for contributing @gmhafiz! 🙌 Everything else seems good to me, once that is done we will move this forward 🎉 💪

@rntdrts rntdrts merged commit 89651f1 into uniplaces:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants