Actions rework #72
Merged
Actions rework #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved actions to get list of groups and create new group to GroupActions
Added new route to get list of groups, by default returns all groups which a user has permission to view, the endpoint also accepts query parameters to filter list of groups by name, workspace, or account
Moved Members related actions to a separate module. The old routes use new actions to view, add, remove members from Group/Workspace
Added GroupCreateRequest for new POST /groups endpoint that will replace workspace/{id}/groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This PR changes organization of actions. The action modules were cleaned up to include only resource related actions. For example, actions to create groups were moved from
workspacemodule togroupsmodule, actions related to policies were moved to the newactions/policy.pymodule, etc.The actions were also reformatted for the upcoming Route Update. Most actions now perform a permission check, as the route based check will be removed in the future. Actions were also upgraded for new query system that will be also included with new Routing system. For example, the action to get groups now accepts arguments such as name, workspace, and account so it is possible to get groups from specified workspace, or if the workspace is omitted, all groups where the user has permissions to view groups will be returned. By analogy, many actions now support arguments which will assist in update for the adding query parameters.
The old route endpoints now use the updated actions and successfully pass the old tests.