Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fsm: improve and convert to interface #178

Merged
merged 2 commits into from
Jan 29, 2023
Merged

fsm: improve and convert to interface #178

merged 2 commits into from
Jan 29, 2023

Conversation

vtolstov
Copy link
Member

@vtolstov vtolstov commented Jan 29, 2023

  • logger: fix Fields func for default logger
  • logger: remove wrappers support
  • logger: remove OmitLogger wrapper
  • fsm: convert to interface
  • fsm: add wrappers support

Signed-off-by: Vasiliy Tolstov v.tolstov@unistack.org

Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2023
@vtolstov vtolstov enabled auto-merge January 29, 2023 21:18
Signed-off-by: Vasiliy Tolstov <v.tolstov@unistack.org>
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #178 (cb743ce) into v3 (4debc39) will decrease coverage by 0.33%.
The diff coverage is 70.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #178      +/-   ##
==========================================
- Coverage   40.92%   40.60%   -0.33%     
==========================================
  Files          97       97              
  Lines        9250     9163      -87     
==========================================
- Hits         3786     3721      -65     
+ Misses       5126     5109      -17     
+ Partials      338      333       -5     
Impacted Files Coverage Δ
logger/options.go 55.55% <ø> (-4.45%) ⬇️
logger/default.go 56.49% <36.36%> (-16.07%) ⬇️
fsm/default.go 72.72% <72.72%> (ø)
fsm/options.go 83.33% <83.33%> (ø)
fsm/fsm.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4debc39...cb743ce. Read the comment docs.

@vtolstov vtolstov merged commit 7462b0b into v3 Jan 29, 2023
@vtolstov vtolstov deleted the fsm branch January 29, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant