-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use special sessions for term start dates #389
base: main
Are you sure you want to change the base?
Conversation
This PR conflicts with your previous one (I think that's the cause of the conflict). Can you re-do? |
Should be fixed. |
I wonder if we shouldn't trust my session data. According to http://content.time.com/time/politics/article/0,8599,2009480,00.html, it may be that only one chamber or the other was in session during a special session, and so that might change what we want to adjust the dates to. Or maybe it doesn't matter. |
That's a good point. The Senate has these two PDFs on its site, one of which has Senate special sessions and one of which has special sessions of both chambers. We could use these as a guide. My concern with using only the regular sessions is that we'll end up leaving out entire terms for legislators who only served during a special session (because they left before the start of the first regular session because of resignation or death). |
I think we're also missing some who were elected to fill a vacancy after the end of the last session. I don't mind missing people who didn't actually serve, but I totally agree that if they served they should be in the data. |
As far as I can tell there are no official records of swearing-in dates for the older sessions. The Senate does have a list of "start of service" dates, but the historian's office says these are not always the same as the date the senator was sworn in. It also appears that for at least some representatives, the start of service listed in Bioguide is the first date of the term's Senate special session (even if the House did not go into session until later). So it seems like for cases where the swearing-in date is unknown, the choices for default term start dates are:
|
+1 |
Should we just merge this and then come back to cases where only one chamber was in session during the special session in a later issue/PR? |
I was still planning to change it to use separate start dates for each chamber. I'd be fine with either merging this and then changing it or leaving the dates as they are and making a new PR...whatever you think is best.
|
Ok that's fine. If you're still working on it, no hurry. |
This corrects term start dates in historical terms, to use, by default, the beginning of the first session of each Congress, even if it's a special session. See #388.
This makes the following changes to start dates:
The dates are based on the GovTrack sessions.tsv file.
I made the changes using this script: https://gist.github.com/bycoffe/b8fdc86dcc0eb26022cf6a38e4286512