335: Improve and fix JavaDoc

Task-Url: #335
unitsofmeasurement · Mar 13, 2021 · d85087a · d85087a
1 parent 243ea9d
commit d85087a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/main/java/tech/units/indriya/unit/UnitDimension.java b/src/main/java/tech/units/indriya/unit/UnitDimension.java
@@ -143,10 +143,8 @@ public class UnitDimension implements Dimension, Serializable {
 	public static <Q extends Quantity<Q>> Dimension of(Class<Q> quantityType) {
 		// TODO: Track services and aggregate results (register custom types)
 		Unit<Q> siUnit = Units.getInstance().getUnit(quantityType);
-		if (siUnit == null) {
-			if (LOGGER.isLoggable(Level.FINE)) {
-				LOGGER.log(Level.FINE, "Quantity type: " + quantityType + " unknown");
-			}
+		if (siUnit == null && LOGGER.isLoggable(Level.FINE)) {
+			LOGGER.log(Level.FINE, "Quantity type: " + quantityType + " unknown");
 		}
 		return (siUnit != null) ? siUnit.getDimension() : null;
 	}

diff --git a/src/main/jdk9/tech/units/indriya/unit/UnitDimension.java b/src/main/jdk9/tech/units/indriya/unit/UnitDimension.java
@@ -147,10 +147,8 @@ public class UnitDimension implements Dimension, Serializable {
 	public static <Q extends Quantity<Q>> Dimension of(Class<Q> quantityType) {
 		// TODO: Track services and aggregate results (register custom types)
 		Unit<Q> siUnit = Units.getInstance().getUnit(quantityType);
-		if (siUnit == null) {
-			if (LOGGER.isLoggable(Level.DEBUG)) {
-				LOGGER.log(Level.DEBUG, "Quantity type: " + quantityType + " unknown");
-			}
+		if (siUnit == null && LOGGER.isLoggable(Level.DEBUG)) {
+			LOGGER.log(Level.DEBUG, "Quantity type: " + quantityType + " unknown");		
 		}
 		return (siUnit != null) ? siUnit.getDimension() : null;
 	}
@@ -308,4 +306,4 @@ public boolean equals(Object obj) {
 	public int hashCode() {
 		return Objects.hashCode(pseudoUnit);
 	}
-}
+}