Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the current implementation of UCUM and bring comments up-to-date #65

Closed
magnonasc opened this issue Mar 18, 2017 · 4 comments
Closed

Comments

@magnonasc
Copy link

magnonasc commented Mar 18, 2017

The UCUM version being used on this implementation is 1.9, and as UCUM is on its 2.0.1 version there is a need to check for changes and fix the comments with missing sections (e.g., TYPESETTER'S LENGTH UNITS: UCUM 4.4 §39 which now is §42) to make it easier to look for them on UCUM documentation when working on #59.

@magnonasc
Copy link
Author

In public static final Unit<Action> PLANCK = addUnit(SI.JOULE_SECOND.multiply(6.6260755E-24)); //FIXME get rid of JXQ import (where from??) on UCUM class, how does this error relates to the wrong value that should be 6.6260755E-34 instead of 6.6260755E-24? Or where you referring to something else? It seems that the build is still okay after fixing that, what makes me confused about your comment.

@keilw
Copy link
Member

keilw commented Mar 18, 2017

I cannot exactly point JXQ to anything still in the current code. It may have been from JScience or an earlier codebase. Should be safe to drop the comment.

@magnonasc
Copy link
Author

magnonasc commented Mar 18, 2017

Okay, so I'll just fix the wrong value and drop the comment... Feel free to assign this issue to me as I'm working on it already.

keilw added a commit that referenced this issue Mar 18, 2017
#65: Updated documentation and fixed some wrong values
@magnonasc
Copy link
Author

Just some typos and two errors were found as part of this issue, the others are just missing and might be added as part of #59.

@keilw keilw removed the ready label Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants