Revise README based on the comments from @hirooih at #5 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
|
@hirooih, can I ask you to review this change? |
hirooih
reviewed
Feb 18, 2021
| @@ -2,7 +2,7 @@ | |||
| Reference codebase for Universal-ctags | |||
There was a problem hiding this comment.
codebase -> Code Base
s/Universal-ctags/Universal Ctags/g
hirooih
reviewed
Feb 18, 2021
| @@ -92,26 +93,38 @@ We assume you may have enough storage space on your PC. | |||
| How to add your code to code base | |||
There was a problem hiding this comment.
A reader may not be the owner of the code.
- How to add a code to the code base
- How to add a project to the code base
- How to add a git project to the code base
The last one don't not require the next sentence.
hirooih
requested changes
Feb 18, 2021
| You may wan to use `--options-maybe` to extend profile without | ||
| modifying existing .ctags files. | ||
| Add a .ctags file under profile.d directory. | ||
| In the .ctags file, a line started from "# @" is used as a |
There was a problem hiding this comment.
Before this sentence you should describe that a line started from "#" is a comment.
And now I found a ".tags file" means a "option file" described in FILES sections of man ctags(1).
If we describe that this is a option file, a reader can understand that he/she can use comment lines starting '#' and the "--options" option can be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Masatake YAMATO yamato@redhat.com