Merge pull request #3726 from b4n/erlang-invalid-pointer

erlang: Fix crash parsing directives longer than 31 characters
universal-ctags · May 20, 2023 · dfabddc · dfabddc
2 parents 3547021 + 8e218a3
commit dfabddc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/Units/parser-erlang.r/crash1.d/input.erl b/Units/parser-erlang.r/crash1.d/input.erl
@@ -0,0 +1,5 @@
+% long directives used to possibly crash the parser
+% (and always make Valgrind angry)
+-some_extremely_loooong_directive
+-even_longer_might_crash_more_often_than_not_but_anyway_valgrind_would_not_be_hayyp_either_way
+
diff --git a/parsers/erlang.c b/parsers/erlang.c
@@ -131,12 +131,12 @@ static void parseDirective (const unsigned char *cp, vString *const module)
 	 * Record definitions are handled separately
 	 */
 	vString *const directive = vStringNew ();
-	const char *const drtv = vStringValue (directive);
 	cp = parseIdentifier (cp, directive);
 	cp = skipSpace (cp);
 	if (*cp == '(')
 		++cp;
 
+	const char *const drtv = vStringValue (directive);
 	if (strcmp (drtv, "record") == 0)
 		parseSimpleTag (cp, K_RECORD);
 	else if (strcmp (drtv, "define") == 0)