Allows ./autogen.sh to be called from another Makefile
#1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Could you write this story(?) you wrote in this pull request to the commit log? To reproduce the problem I was having create the following makefile: .PHONY: ctags
ctags:
./autogen.sh... |
To reproduce the problem create the following makefile: ```make .PHONY: ctags ctags: ./autogen.sh ``` Then call it, you should see output as following: ``` ./autogen.sh autoreconf is /usr/bin/autoreconf pkg-config is /usr/bin/pkg-config autoreconf: Entering directory `.' autoreconf: configure.ac: not using Gettext autoreconf: running: aclocal --force autoreconf: configure.ac: tracing autoreconf: configure.ac: not using Libtool autoreconf: running: /usr/bin/autoconf --force autoreconf: running: /usr/bin/autoheader --force autoreconf: running: automake --add-missing --copy --force-missing configure.ac:262: installing './compile' configure.ac:23: installing './config.guess' configure.ac:23: installing './config.sub' configure.ac:11: installing './install-sh' configure.ac:11: installing './missing' Makefile.am: installing './depcomp' /usr/share/automake-1.15/am/tags.am: warning: redefinition of 'ctags' ... /usr/share/automake-1.15/am/program.am: ... 'ctags$(EXEEXT)' previously defined here Makefile.am:15: while processing program 'ctags' autoreconf: Leaving directory `.' optlib2c: translating make[1]: to make[1]:.c cannot open the optlib file: "make[1]:" at ./misc/optlib2c line 266. optlib2c: translating Entering to Entering.c cannot open the optlib file: "Entering" at ./misc/optlib2c line 266. optlib2c: translating directory to directory.c cannot open the optlib file: "directory" at ./misc/optlib2c line 266. optlib2c: translating '/home/sdwolf/Projects/ctags' to '/home/sdwolf/Projects/ctags'.c ./autogen.sh: line 13: '/home/sdwolf/Projects/ctags'.c: No such file or directory optlib2c: translating optlib/RSpec.ctags to optlib/RSpec.c optlib2c: translating optlib/ctags-optlib.ctags to optlib/ctags-optlib.c optlib2c: translating optlib/elm.ctags to optlib/elm.c optlib2c: translating optlib/gdbinit.ctags to optlib/gdbinit.c optlib2c: translating optlib/man.ctags to optlib/man.c optlib2c: translating optlib/passwd.ctags to optlib/passwd.c optlib2c: translating optlib/pod.ctags to optlib/pod.c optlib2c: translating optlib/qemuhx.ctags to optlib/qemuhx.c optlib2c: translating make[1]: to make[1]:.c cannot open the optlib file: "make[1]:" at ./misc/optlib2c line 266. optlib2c: translating Leaving to Leaving.c cannot open the optlib file: "Leaving" at ./misc/optlib2c line 266. optlib2c: translating directory to directory.c cannot open the optlib file: "directory" at ./misc/optlib2c line 266. optlib2c: translating '/home/sdwolf/Projects/ctags' to '/home/sdwolf/Projects/ctags'.c ./autogen.sh: line 13: '/home/sdwolf/Projects/ctags'.c: No such file or directory make: *** [Mak:3: ctags] Error 1 ``` This is because `make -f makefiles/list-translator-input.mak` produces the following output when being called from another Makefile: ``` make -f makefiles/list-translator-input.mak make[1]: Entering directory '/home/sdwolf/Projects/ctags' optlib/RSpec.ctags optlib/ctags-optlib.ctags optlib/elm.ctags optlib/gdbinit.ctags optlib/man.ctags optlib/passwd.ctags optlib/pod.ctags optlib/qemuhx.ctags make[1]: Leaving directory '/home/sdwolf/Projects/ctags' ``` When instead it should only output: ``` optlib/RSpec.ctags optlib/ctags-optlib.ctags optlib/elm.ctags optlib/gdbinit.ctags optlib/man.ctags optlib/passwd.ctags optlib/pod.ctags optlib/qemuhx.ctags ```
|
I've updated the commit with the relevant part of the bug description. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the problem I was having create the following makefile:
Then call it, you should see output as following:
This is because
make -f makefiles/list-translator-input.makproduces the following output when being called from another Makefile:When instead it should only output:
I stumbled upon this while creating an ansible playbook for ctags. When running it with:
everything went fine, but I wanted to run that command from a makefile because:
is easyer to type.