-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update readtags to support escape sequences and fix & improve its testing #1605
Closed
Closed
Changes from 15 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
3d7f38f
readtags: Add support for escape sequences in tag names
b4n a6e4bde
testing: Don't unconditionally silent test rules
b4n 72fc6df
testing: Define $(SILENT)
b4n 215abb1
roundtrip: Cleanup and fix so it actually does check something
b4n a9433ab
roundtrip: Try and match unescaped names too
b4n 5692578
Run roundtrip on make check
b4n d59b3af
roundtrip: Fix running on non-C locales
b4n 378c53e
roundtrip: Try and fix macos compatibility
b4n c814e65
readtags: Build with coverage support if requested
b4n 21a8b0e
WIP: roundtrip: add debugging output because of Windows
b4n 247a93b
roundtrip: Fix unescaping
b4n df5e6bd
roundtrip: Fix handling of escaped newlines
b4n e2dc477
readtags: Don't expect escaped search string
b4n 0714968
roundtirp: Improve message for failing tests
b4n 4bae9ed
fixup! roundtrip: Fix unescaping
b4n cd6c100
roundtrip: Fix handling of trailing newlines
b4n 2b51abe
fixup! readtags: Add support for escape sequences in tag names
b4n f7ade0c
roundtrip: Exit on command failure
b4n 0d502b3
circleci: Install find for roundtrip
b4n e441795
roundtrip: Fix MacOS compatibility
b4n 15fe94c
roundtrip: Fix some escaping cases
b4n 3b19b37
fixup! WIP: roundtrip: add debugging output because of Windows
b4n 386a0a1
roundtrip: Further OSX fixing (hopefully)
b4n 143075b
roundtrip: Add a test case for all escape sequences
b4n 9e56104
roundtrip: Don't hide error output from readtags
b4n 11b9d16
readtags: Add debugging info
b4n a4f9247
fixup! roundtrip: Further OSX fixing (hopefully)
b4n 168eb2a
roundtrip: Try and workaround AppVeyor/MSYS2 weirdness
b4n 0ed2741
fixup! roundtrip: Try and workaround AppVeyor/MSYS2 weirdness
b4n 341db19
roundtrip: Try and actually fix erroneous MSYS2 path rewrites
b4n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you tell me why this change is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not needed per se, but I changed the name for clarity as it's not only used for the last backslash but for all literal backslashes