-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NULL check #1656
Fix NULL check #1656
Conversation
The result is obviously improved.
Actually, with your patch, u-ctags generates the same tags file as e-ctags generates. I will a pull request to your branch. So could you push it here? ( |
…ags#1656 Signed-off-by: Masatake YAMATO <yamato@redhat.com>
(Thank you for pushing my change.) |
Merged
Sorry about that, next time I'll do it right. (This was my first PR) |
Let's wait for the response from the maintainer of C/C++ parsers.
I'm very proud of u-ctags project attracting a new hacker. I hope that you enjoy hacking u-ctags more. So I would like to add more comments here.
Here Knowing how to write a test case is important in this project. Please look at my patch which I submitted to your branch. See also http://docs.ctags.io/en/latest/units.html . Thank you. |
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Yep, looks good! |
(Didn't have time to reply yesterday)
I don't know if I'll stay for long or contribute much to the project, but I'd like to at least try.
Not sure about those requirements, it seems to me there's a lot to learn before I can even grasp the ctags big picture and contribute something more valuable... (this PR shows exactly that, a C bug, didn't make tests or anything)
Done, was that what you wanted? Tell me if there's anything missing |
Thank you. |
Fix #1655