-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Matlab classes #1791
Conversation
end | ||
end | ||
end | ||
|
||
function [x,y,z] = func1 | ||
function x = func2 | ||
function func3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the test case for testing what you wrote:
and allow for functions not to be
defined in the first column but to be indented by white space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: I added the two missing function types of this kind as class methods.
@@ -1,3 +1,10 @@ | |||
classdef class1 < handle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question. Here "handle" is the super class of "class1"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is correct. The handle
class is actually a special class, changing the semantics of the derived class.
Recognize the definition of a class, and allow for functions not to be defined in the first column but to be indented by white space.
Thank you. BTW, could you help us more to improve matlab parser? Could you look at matlab_backtracking.m.t/{input.m,expected.tags} and matlab_test.m.t/{input.m,expected.tags} and give me feedback ? If you say they are o.k., I will move the cases to Unix/parser-matlab.r, a new directory. |
See #1792 |
Recognize the definition of a class, and allow for functions not to be
defined in the first column but to be indented by white space.