Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced protected attribute for Fortran #1808

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

p-vitt
Copy link
Contributor

@p-vitt p-vitt commented Jul 30, 2018

The protected attribute in Fortran is used to make a module variable readable, but not editable from outside. However, public module variables marked with the protected attribute were omitted when the file was parsed. Therefore, I added the protected attribute.

@coveralls
Copy link

coveralls commented Jul 30, 2018

Coverage Status

Coverage remained the same at 84.412% when pulling b26dfca on p-vitt:fortran-protected into 3522685 on universal-ctags:master.

@b4n
Copy link
Member

b4n commented Jul 30, 2018

Looks probably good, but could you add a test case please?

@masatake
Copy link
Member

Surprisingly protected attr and public attr can be used together in the same field :-0

https://www.ibm.com/support/knowledgecenter/SSGH4D_14.1.0/com.ibm.xlf141.aix.doc/language_ref/protected.html

Copy link
Member

@masatake masatake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash this commit("fixed typo") into the previous commit ("Added unit test for the protected attribute") to keep the history simple.

@p-vitt
Copy link
Contributor Author

p-vitt commented Jul 30, 2018

Sure, need to look up how to (I'm more used to mercurial), but I guess I'll find out :)

@masatake
Copy link
Member

I'm more used to mercurial.
Oh, I see.

git rebase -i and git push --force may help you.

@masatake masatake merged commit e65e91a into universal-ctags:master Jul 30, 2018
@masatake
Copy link
Member

Thank you.

@p-vitt p-vitt deleted the fortran-protected branch July 31, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants