Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot: remove empty expression .{0} in parsers/robots.c to fix unit test tmain and units on FreeBSD #1866

Merged

Commits on Sep 5, 2018

  1. Remove empty expression

    Running unit tests tmain and units via 'make check' the empty expression
    .{0} from the matching group in parsers/robot.c was causing FreeBSD libc
    regcomp to produce an error: empty (sub)expression.
    
    tmain would fail for some checks while units would fail for robots checks.
    
    Removing the emptry expression .{0} "match anything exactly zero times"
    fixes this issue and all expected tests pass for both tmain and units.
    
    Testing the same change, removing the expression .{0} from the
    matching group, on centos7 does not appear to have any regessions.
    
    This reverts the following commit
    universal-ctags@81a4593
    
    That was created for the following issue:
    universal-ctags#1571 (comment)
    
    It's possible there's some regression for macOS however macOS on Travis
    doesn't seem to have any issues.
    derekschrock committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    0e10675 View commit details
    Browse the repository at this point in the history