Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locate packcc in build directory instead of the source #2030

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Conversation

Myz
Copy link
Contributor

@Myz Myz commented Mar 5, 2019

This should fix a Out-of-source or nested build.

Related to #2029.

This should fix a Out-of-source or nested build.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.237% when pulling 5de4826 on Myz:master into affa2f7 on universal-ctags:master.

@b4n
Copy link
Member

b4n commented Mar 5, 2019

Looks reasonable. We should have an out-of-tree build on CI I guess, it's always nice to catch these kind of things early.

@masatake
Copy link
Member

masatake commented Mar 5, 2019

NOTE: out-of-tree build can be done with cd $(mktemp -d) && git clone https://github.com/universal-ctags/ctags.git && cd ctags && ./autogen.sh && mkdir mybuild && cd mybuild && ../configure && make -j10 as @Myz written in #2029.

@masatake masatake merged commit 6cecfb9 into universal-ctags:master Mar 5, 2019
@masatake
Copy link
Member

masatake commented Mar 5, 2019

Thank you!

@Myz
Copy link
Contributor Author

Myz commented Mar 5, 2019

Anytime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants