readtags should be able to read tag files generated for the excmd "combine" #2125
Conversation
…d=combine. Previously the reader would discard everything beyond the first semicolon in the search expression. This was unfortunate because when using the 'combine' option the full search expression has the form <line number>;<search expression>.
|
Thank you. You don't have to touch any Makefiles. |
|
You are welcome!
I will have a look at your example test case and see if I can add a test case for the change that I am suggesting.
I will notify you when it’s done.
Venlig hilsen / Best regards,
Claus Moltke-Leth
Software Engineer
+45 87 33 53 29
cml@ccieurope.com<mailto:cml@ccieurope.com>
[cid:452DB88F-416A-4FBF-AF8B-DC1671AF947A@stibo.corp]
CCI Europe A/S | Axel Kiers Vej 11, 8270 Højbjerg, Denmark |
+45 87 33 55 88 | www.ccieurope.com<http://www.ccieurope.com>
Den 28. jun. 2019 kl. 21.02 skrev Masatake YAMATO <notifications@github.com<mailto:notifications@github.com>>:
Thank you.
Could you add a test case for the bug?
See Tmain/readtags-*.d directories.
See also http://docs.ctags.io/en/latest/tmain.html
You don't have to touch any Makefiles.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2125?email_source=notifications&email_token=AMPFW3J2U3YTYNOHRKKO5RLP4ZN2VA5CNFSM4H4FKERKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY25IPY#issuecomment-506844223>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMPFW3I32Q6VDKOSNQMFFOTP4ZN2VANCNFSM4H4FKERA>.
|
|
I have now provided two simple test cases. Should I then close the pull request? |
Tmain/readtags-combine.d/run.sh
Outdated
| @@ -1,8 +1,5 @@ | |||
| #!/bin/sh | |||
|
|
|||
| # Copyright: 2016 Masatake YAMATO | |||
| # License: GPL-2 | |||
|
|
|||
There was a problem hiding this comment.
Please, add YOUR copyright notice instead.
There was a problem hiding this comment.
Would the copyright notice be that of the company I am working for (CCI Europe) or just me personally?
We are using ctags to be able to easily browse our code using the vim editor.
My suggestion would be something like the below. Please advise, I am new to open source contribution. Thanks in advance!
Copyright: 2019 CCI Europe. Author: Claus Moltke-Leth
License: GPL-2
There was a problem hiding this comment.
It may be up to the relation between your and your company.
Did you write the run.sh as part of your job?
In that case, the copyright notice you showed looks good for me.
There was a problem hiding this comment.
I have included copyright information now. As far as I am concerned, the pull request is complete. Should I close it, or will you do it?
|
The test case itself is o.k. Thank you. |
Codecov Report
@@ Coverage Diff @@
## master #2125 +/- ##
==========================================
+ Coverage 85.86% 85.87% +<.01%
==========================================
Files 173 173
Lines 34746 34757 +11
==========================================
+ Hits 29835 29846 +11
Misses 4911 4911
Continue to review full report at Codecov.
|
|
Thank you. |
Currently the reader would discard everything beyond the first semicolon in the search expression. This was unfortunate because when using the 'combine' option the full search expression has the form ;.
For example, listing tag entries named LogReport would produce only:
This has been fixed so that readtags now outputs all fields from the tags file: