Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pascal: Parse first type identifier #2241

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Oct 16, 2019

This is a change ported from Geany. Needs tests.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 86.311% when pulling ea47066 on ntrel:pas-type into 1da4659 on universal-ctags:master.

@masatake
Copy link
Member

Test cases under review-needed.r were imported from exuberant-ctags.
As the directory name shows, we don't understand what kind of tags output is expected for the input.

If you know Pascal, I would like you to review the test case first.
If you don't want to review, introduce a new test case for your change instead of extending
review-needed.r/bug612019.pas.t.

@ntrel
Copy link
Contributor Author

ntrel commented Oct 22, 2019

I would like you to review the test case first

Test case looks fine.

introduce a new test case for your change instead of extending
review-needed.r/bug612019.pas.t

This pull will modify the tags generated by the existing test case. All I did was add a function.

@masatake
Copy link
Member

Test case looks fine.
Thank you.

This pull will modify the tags generated by the existing test case. All I did was add a function.

Your work is nothing to do with bug612019.pas, isn't it?
The name of the test case points a bug report at Exuberant-ctags project run at Sourceforge.

@ntrel
Copy link
Contributor Author

ntrel commented Oct 22, 2019

Test case looks fine

Although the procedures and function (which I added) should maybe have an empty parameter list.

@ntrel
Copy link
Contributor Author

ntrel commented Oct 22, 2019

Your work is nothing to do with bug612019.pas, isn't it?

It has a type declaration.

@masatake
Copy link
Member

It has a type declaration.

Do you mean the original test input has a type declaration, and so you reuse the test input for your work?

@@ -1,3 +1,4 @@
Test1 input.pas /^ procedure Test1;$/;" p
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test1 is not tagged with the change.

masatake added a commit to masatake/ctags that referenced this pull request Dec 2, 2021
masatake pushed a commit to masatake/ctags that referenced this pull request Dec 2, 2021
Close universal-ctags#2241.

@mastake's note:
This pull chnage is based on universal-ctags#2241 submitted by @ntrel.
I adjust the change not to fill "signature" field for tags of "type" kind.
I also adjust the change to avoid regression.
@masatake masatake mentioned this pull request Dec 2, 2021
masatake added a commit to masatake/ctags that referenced this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants