Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packcc: add EXTRA_CFLAGS to packcc_CFLAGS #2305

Merged
merged 1 commit into from
Nov 10, 2019
Merged

packcc: add EXTRA_CFLAGS to packcc_CFLAGS #2305

merged 1 commit into from
Nov 10, 2019

Conversation

julianaito
Copy link
Contributor

@julianaito julianaito commented Nov 9, 2019 •
edited

packcc includes initial declarations in for loops, but does not inherit EXTRA_CFLAGS (and notably -std=gnu99) as found by autotools, unlike ctags.

As such, if the compiler uses a C<99 standard by default, packcc's build breaks

I'm just proposing to add EXTRA_CFLAGS to packcc_CFLAGS.

@julianaito
packcc: add EXTRA_CFLAGS to packcc_CFLAGS
ec55ffa 
This allows building with old compilers that don't have C99+ as default
standard.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.32% when pulling ec55ffa on julianaito:extra-cflags into be621ae on universal-ctags:master.

k-takata
k-takata approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@k-takata k-takata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-takata k-takata merged commit be7b72c into universal-ctags:master Nov 10, 2019
@masatake
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-takata k-takata k-takata approved these changes

Assignees

@k-takata k-takata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julianaito @coveralls @masatake @k-takata