SystemVerilog: support struct and union member

[hirooih]

Struct and union members are emitted by this fix.
The kind "member" (w) is added. (m and M were already used.)

Enum items are emitted in the defined order with --sort=no option.

[codecov]

Codecov Report

Merging #2701 (3173073) into master (ea5214b) will increase coverage by 0.00%.
The diff coverage is 95.65%.

@@           Coverage Diff           @@
##           master    #2701   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files         185      185           
  Lines       39441    39466   +25     
=======================================
+ Hits        34310    34333   +23     
- Misses       5131     5133    +2     

Impacted Files	Coverage Δ
parsers/verilog.c	98.59% <95.65%> (-0.27%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea5214b...3173073. Read the comment docs.

[coveralls]

Coverage increased (+0.003%) to 87.082% when pulling 3173073 on hirooih:sv-struct-member into e37e2ef on universal-ctags:master.

[masatake]

...I don't like this change and the original code.
See the field used in popToken and pushToken. These functions use scope field.
These functions are originally written for tracking scope information.
See the comment for scope:

	struct sTokenInfo*  scope;         /* context of keyword */

However, the change and the original code abuse them for dealing with a sequence.
I think this is a bad idea.

Do you know ptrArray (main/ptrarray.h) ?

You can use ptrArray to store the sequence of tokens.
#2702 illustrates how to use ptrArray.

[hirooih]

...I don't like this change and the original code.

I don't like it, either. But I also don't like to reinventing the wheels.
I reused the code which was already in verilog.c.

Do you know ptrArray (main/ptrarray.h) ?

No, I did not.
AFAIK we don't have a list of API which a parser can use. Can we use any external functions defined in main/*.h?

I have a question related to this topic.
Is there API to get the filename which a parse is parsing?

I will update verilog.c to use ptrArray.

[masatake]

AFAIK we don't have a list of API which a parser can use. Can we use any external functions defined in main/*.h?

No, we don't have.
We have one rule; we should not use functions and types declared in main/*_p.h in parsers. _p means "private in main."\

I have a question related to this topic.
Is there API to get the filename which a parse is parsing?

Yes, you can use getInputFileName() declared in main/read.h.

I will update verilog.c to use ptrArray.

I would like you to see #2702 and merge it if it is o.k.

[hirooih]

We have one rule; we should not use functions and types declared in main/*_p.h in parsers. _p means "private in main."

I see. This means we do have a list of API.

Yes, you can use getInputFileName() declared in main/read.h.

Thanks.

I would like you to see #2702 and merge it if it is o.k.

You raised the bar! It will cause conflicts.
It will be my first experience of review on GitHub.

[hirooih]

@masatake san,

How about this? Please review again.
Thank you.