Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemVerilog: exit loop on EOF #2733

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Conversation

hirooih
Copy link
Contributor

@hirooih hirooih commented Nov 26, 2020

There were 8 bugs which cause infinite loop due to lack of EOF check.
While checking loops, loops which can be refactored were found and fixed.

I do not add test cases for this issue, because we need a unit case for each loop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.927% when pulling 54b431e on hirooih:sv-eof-on-loop into 4f69a72 on universal-ctags:master.

@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #2733 (54b431e) into master (4f69a72) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2733      +/-   ##
==========================================
- Coverage   86.83%   86.83%   -0.01%     
==========================================
  Files         189      189              
  Lines       40251    40250       -1     
==========================================
- Hits        34953    34952       -1     
  Misses       5298     5298              
Impacted Files Coverage Δ
parsers/verilog.c 98.17% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f69a72...54b431e. Read the comment docs.

@hirooih hirooih merged commit e1acc8d into universal-ctags:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants