Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia: correctly recognize Module.@macro as a macro call #2788

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

getzze
Copy link
Contributor

@getzze getzze commented Jan 3, 2021

@eval fun1(x) = $a
Base.@eval fun2(x) = $a

fun2 is not recognized as a short function, because Base.@eval is not recognized as a macro (with scope).

(currently fun1 is also not parsed but it will be corrected by #2790).

This is a work in progress, it should be implemented using the new cork system introduced by #2763.
It is working now!

@AmaiKinono
Copy link
Member

Actually in #2763 I didn't chose to use cork, so the mechanism dealing with scope is still the one you introduced.

@getzze
Copy link
Contributor Author

getzze commented Jan 5, 2021

I don't understand what happens when I rebase, some other commits appear. Can you just cherry-pick the last commit, 7d04c71 ?

@getzze
Copy link
Contributor Author

getzze commented Jan 6, 2021

ok, I managed to clean the commit tree, it can be merged.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #2788 (7ea3b2f) into master (16dbda1) will increase coverage by 0.00%.
The diff coverage is 98.24%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2788   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files         193      193           
  Lines       44075    44076    +1     
=======================================
+ Hits        38336    38337    +1     
  Misses       5739     5739           
Impacted Files Coverage Δ
parsers/julia.c 96.55% <98.24%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16dbda1...7ea3b2f. Read the comment docs.

@masatake
Copy link
Member

Please, wait for awhile.
I'm struggling the trouble in the build-system.

@masatake
Copy link
Member

masatake commented Jan 16, 2021

I will review this one after merging #2727.

@masatake
Copy link
Member

@getzze, can I ask you to resolve the conflicts?

@masatake masatake merged commit a4f1d81 into universal-ctags:master Jan 18, 2021
@masatake
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants