-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Julia: correctly recognize Module.@macro as a macro call #2788
Conversation
Actually in #2763 I didn't chose to use cork, so the mechanism dealing with scope is still the one you introduced. |
908a519
to
7d04c71
Compare
I don't understand what happens when I rebase, some other commits appear. Can you just cherry-pick the last commit, 7d04c71 ? |
7d04c71
to
85cfe43
Compare
ok, I managed to clean the commit tree, it can be merged. |
Codecov Report
@@ Coverage Diff @@
## master #2788 +/- ##
=======================================
Coverage 86.97% 86.97%
=======================================
Files 193 193
Lines 44075 44076 +1
=======================================
+ Hits 38336 38337 +1
Misses 5739 5739
Continue to review full report at Codecov.
|
Please, wait for awhile. |
I will review this one after merging #2727. |
@getzze, can I ask you to resolve the conflicts? |
85cfe43
to
62c61d6
Compare
62c61d6
to
7ea3b2f
Compare
Thank you. |
fun2
is not recognized as a short function, becauseBase.@eval
is not recognized as a macro (with scope).(currently
fun1
is also not parsed but it will be corrected by #2790).This is a work in progress, it should be implemented using the new cork system introduced by #2763.It is working now!