-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for Function::Parameters parser #2868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
@@ -0,0 +1,3 @@ | |||
fun input.c /^int fun(void) $/;" f typeref:typename:int | |||
method input.c /^int method(void) $/;" f typeref:typename:int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A whitespace after (void)
is not needed.
@@ -0,0 +1,3 @@ | |||
fun input.c /^int fun(void) $/;" f typeref:typename:int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A whitespace after (void)
is not needed.
@@ -0,0 +1,3 @@ | |||
fun input.c /^int fun(void) $/;" f typeref:typename:int | |||
method input.c /^int method(void) $/;" f typeref:typename:int | |||
sub input.c /^int sub(void) $/;" f typeref:typename:int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A whitespace after (void)
is not needed.
@@ -0,0 +1,14 @@ | |||
int method(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...becase there is no whitespace after (void)
.
@@ -0,0 +1,3 @@ | |||
fun input.py /^def fun():$/;" f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctags never runs Perl parser ( and FunctionParameter subparser ) for .py files.
So this test case doesn't make sense as a test case for FunctionParameter subparser.
This test case tests the main part of ctags.
Please remove this test case.
Codecov Report
@@ Coverage Diff @@
## master #2868 +/- ##
==========================================
+ Coverage 86.99% 87.09% +0.09%
==========================================
Files 194 194
Lines 44133 44380 +247
==========================================
+ Hits 38395 38654 +259
+ Misses 5738 5726 -12
Continue to review full report at Codecov.
|
Thank you! |
Thanks for your help with the parser. I wish I could have done it but I
dont know C that well.
…On Mon, Feb 15, 2021, 8:10 PM Masatake YAMATO ***@***.***> wrote:
Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2868 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGY4TI7OG5R26W2KSTBQR3S7HAZDANCNFSM4XTZMEQA>
.
|
I got a question. c-fp-test.d/input.c is not for testing FunctionParameters as I wrote python-fp-test.d, isn't it? |
Well I added tests for C and Python to prove the parser didn't try go
beyond the Perl files.
…On Mon, Feb 15, 2021, 8:18 PM Masatake YAMATO ***@***.***> wrote:
I got a question. c-fp-test.d/input.c is not for testing
FunctionParameters as I wrote python-fp-test.d, isn't it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2868 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGY4TPHQAADTYADVIXTNS3S7HBWFANCNFSM4XTZMEQA>
.
|
I deleted them in #2870 there is no code choosing a parser in the FunctionParameters subparser and Perl parser. |
OK I see, I had just added to make sure the parser didnt pick them up.
…On Mon, Feb 15, 2021 at 8:28 PM Masatake YAMATO ***@***.***> wrote:
Well I added tests for C and Python to prove the parser didn't try go
beyond the Perl files.
I deleted them in #2870
<#2870> there is no code
choosing a parser in the FunctionParameters subparser and Perl parser.
The testing cases for choosing a parser for an input file are at Tmain
directory.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2868 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGY4TNKQHY6V76EARIGN4DS7HC3ZANCNFSM4XTZMEQA>
.
|
I added some tests for the Perl Function::Parameters parser