Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmain(client): add test for vista.vim #2875

Merged
merged 3 commits into from
Feb 17, 2021

Conversation

liuchengxu
Copy link
Contributor

The command used in the test is hardcoded as the command used in vista.vim is very stable now.

Ref liuchengxu/vista.vim#386 (comment)

liuchengxu referenced this pull request in masatake/ctags Feb 17, 2021
<REMOVE ME>
This is an example for a test case verifying ctags satisfies an expection of a client tool.

* See <https://docs.ctags.io/en/latest/tips.html#tmain-a-facility-for-testing-main-part> to
  write and run a test case for Tmain target.
* Use `Tmain: ` as the prefix of the header of the commit log.
* Put files composint a test case to Tmain/client-<the name of client>-<aspect of testing>.d/ .
* Put a README Tmain/client-<the name of client>-<aspect of testing>.d/ in addition to putting
  the standard Tmain test files like run.sh. The README is the message to developers of u-ctags.
* Don't include unessary white-spaces in README and run.sh.
</REMOVE ME>

<REMOVE ME: MY TODO>
I must write this to our docs.
</REMOVE ME: MY TODO>
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #2875 (d004154) into master (bf27b48) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2875   +/-   ##
=======================================
  Coverage   87.09%   87.10%           
=======================================
  Files         194      194           
  Lines       44387    44387           
=======================================
+ Hits        38661    38664    +3     
+ Misses       5726     5723    -3     
Impacted Files Coverage Δ
main/parse.c 95.86% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf27b48...46cda22. Read the comment docs.

Copy link
Member

@masatake masatake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the commit log to

Tmain(client): add test for vista.vim

Ref liuchengxu/vista.vim#386 (comment)

Tmain/client-vista-vim-fields-expectation.d/run.sh Outdated Show resolved Hide resolved
Tmain/client-vista-vim-fields-expectation.d/run.sh Outdated Show resolved Hide resolved
@liuchengxu liuchengxu changed the title Add test for vista.vim Tmain(client): add test for vista.vim Feb 17, 2021
@masatake masatake merged commit 4b54332 into universal-ctags:master Feb 17, 2021
@masatake
Copy link
Member

Thank you. Merged after squashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants