Use `&X[3]` instead of `X + 3` to fix clang warnings #3151

rootkea · 2021-09-06T08:28:19Z

Hello!

On latest master clang version 10.0.0-4ubuntu1 produces following warnings:

parsers/lisp.c:128:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("DEFUN"))
                    ^~~~~~~~~~~~
parsers/lisp.c:123:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:128:7: note: use array indexing to silence this warning
parsers/lisp.c:123:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:133:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("DEFVAR"))
                    ^~~~~~~~~~~~~
parsers/lisp.c:123:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:133:7: note: use array indexing to silence this warning
parsers/lisp.c:123:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:138:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("DEFMACRO"))
                    ^~~~~~~~~~~~~~~
parsers/lisp.c:123:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:138:7: note: use array indexing to silence this warning
parsers/lisp.c:123:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:143:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("DEFCONSTANT"))
                    ^~~~~~~~~~~~~~~~~~
parsers/lisp.c:123:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:143:7: note: use array indexing to silence this warning
parsers/lisp.c:123:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:163:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("defun"))
                    ^~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:163:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:168:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("defvar"))
                    ^~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:168:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:170:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("defun*"))
                         ^~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:170:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:175:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("defface"))
                    ^~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:175:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:179:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("defconst"))
                    ^~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:179:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:181:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("defmacro"))
                         ^~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:181:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:183:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("defalias"))
                         ^~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:183:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:185:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("defsubst"))
                         ^~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:185:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:187:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("defgroup"))
                         ^~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:187:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:189:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("deftheme"))
                         ^~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:189:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:194:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("defcustom"))
                    ^~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:194:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:196:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("defsubst*"))
                         ^~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:196:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:198:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("defmacro*"))
                         ^~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:198:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:203:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("define-key"))
                    ^~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:203:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:208:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("defvar-local"))
                    ^~~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:208:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:210:12: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                else if (EQN("define-error"))
                         ^~~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:210:12: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:215:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("defvaralias"))
                    ^~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:215:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:220:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("define-inline"))
                    ^~~~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:220:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:225:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("define-minor-mode"))
                    ^~~~~~~~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:225:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:230:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("define-derived-mode"))
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:230:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:235:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("define-global-minor-mode"))
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:235:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:240:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("define-globalized-minor-mode"))
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:240:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^
parsers/lisp.c:245:7: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int]
                if (EQN("define-obsolete-function-alias"))
                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                ~~^~~
parsers/lisp.c:245:7: note: use array indexing to silence this warning
parsers/lisp.c:158:51: note: expanded from macro 'EQN'
#define EQN(X) strncmp(vStringValue (hint) + 4, X + 3, n) == 0
                                                  ^

This PR fixes these warnings.

Thanks!

codecov · 2021-09-06T09:06:40Z

Codecov Report

Merging #3151 (aec0c38) into master (ca81123) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3151   +/-   ##
=======================================
  Coverage   84.89%   84.89%           
=======================================
  Files         200      200           
  Lines       47827    47827           
=======================================
  Hits        40604    40604           
  Misses       7223     7223

Impacted Files	Coverage Δ
parsers/lisp.c	`89.26% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca81123...aec0c38. Read the comment docs.

masatake · 2021-09-06T09:21:25Z

Thank you.

Use &X[3] instead of X + 3 to fix clang warnings

aec0c38

rootkea force-pushed the small-fixes branch from cad7e5b to aec0c38 Compare September 6, 2021 08:33

rootkea changed the title ~~Use &X[3] instead of X + 3 to fix clang warning~~ Use &X[3] instead of X + 3 to fix clang warnings Sep 6, 2021

masatake approved these changes Sep 6, 2021

View reviewed changes

masatake merged commit 9a7b9bc into universal-ctags:master Sep 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `&X[3]` instead of `X + 3` to fix clang warnings #3151

Use `&X[3]` instead of `X + 3` to fix clang warnings #3151

rootkea commented Sep 6, 2021

codecov bot commented Sep 6, 2021 •

edited

Loading

masatake commented Sep 6, 2021

Use &X[3] instead of X + 3 to fix clang warnings #3151

Use &X[3] instead of X + 3 to fix clang warnings #3151

Conversation

rootkea commented Sep 6, 2021

codecov bot commented Sep 6, 2021 • edited Loading

Codecov Report

masatake commented Sep 6, 2021

Use `&X[3]` instead of `X + 3` to fix clang warnings #3151

Use `&X[3]` instead of `X + 3` to fix clang warnings #3151

codecov bot commented Sep 6, 2021 •

edited

Loading