SQL: allow identifier with placeholder such as '${a_1}' #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masatake
force-pushed
the
sql--var-subst
branch
3 times, most recently
from
1c961c6
to
1c9086b
Compare
Close universal-ctags#3169. Some(?) dialects support shell-like variable substitution. HiveQL is one of such dialects. https://cwiki.apache.org/confluence/display/Hive/LanguageManual+VariableSubstitution With this change, the SQL parser accepts '${var}' as a part of an identifier. TODO: `var` itself can be extracted as a reference tag. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
sql--var-subst
branch
from
1c9086b
to
2a2e24c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3172 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 200 200
Lines 47874 47908 +34
=======================================
+ Hits 40648 40678 +30
- Misses 7226 7230 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3169.
Some? dialects support shell-like variable substitution.
HiveQL is one of such dialects.
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+VariableSubstitution
With this change, the SQL parser accepts '${var}' as a part of an identifier.
TODO:
varitself can be extracted as a reference tag.Signed-off-by: Masatake YAMATO yamato@redhat.com