-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Readme: Grammar #3179
Docs: Readme: Grammar #3179
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3179 +/- ##
==========================================
+ Coverage 84.64% 84.81% +0.17%
==========================================
Files 201 205 +4
Lines 47982 48260 +278
==========================================
+ Hits 40612 40931 +319
+ Misses 7370 7329 -41
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have more major features them ones listed here.
These are some of them.
So I think it is better to keep "of" here.
My understanding is as follows:
If a sentence is complete, use ":".
The followings are of some major features of Universal Ctags:
If a sentence is not complete, use ";".
Some of major features of Universal Ctags are;
This is the middle of a sentence , "XXX are A, B, C, and D".
I've searched the usage of semicolon, and could not find any good evidences.
@hirooih "There are more major features than those listed here" is covered by the word "Some" If y'all want to keep "of", it should be "Some of the major features" |
I see.
or
Thanks. |
In accordance with universal-ctags#3179 (comment)
@hirooih Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@masatake san, |
Yes, please. |
Thank you. |
No description provided.