Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Readme: Grammar #3179

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Docs: Readme: Grammar #3179

merged 2 commits into from
Nov 24, 2021

Conversation

Jonta
Copy link
Contributor

@Jonta Jonta commented Oct 24, 2021

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #3179 (e347c55) into master (6f544df) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3179      +/-   ##
==========================================
+ Coverage   84.64%   84.81%   +0.17%     
==========================================
  Files         201      205       +4     
  Lines       47982    48260     +278     
==========================================
+ Hits        40612    40931     +319     
+ Misses       7370     7329      -41     
Impacted Files Coverage Δ
peg/kotlin_post.h 87.75% <0.00%> (-1.48%) ⬇️
peg/varlink_post.h 93.87% <0.00%> (-1.37%) ⬇️
main/lregex.c 83.08% <0.00%> (-0.57%) ⬇️
main/parse.c 95.71% <0.00%> (-0.08%) ⬇️
main/entry.c 88.57% <0.00%> (ø)
parsers/dts.c 100.00% <0.00%> (ø)
main/options.c 83.75% <0.00%> (ø)
main/vstring.h 100.00% <0.00%> (ø)
parsers/make.c 100.00% <0.00%> (ø)
main/numarray.c 33.33% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f544df...e347c55. Read the comment docs.

@masatake masatake requested a review from hirooih October 25, 2021 01:01
Copy link
Contributor

@hirooih hirooih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have more major features them ones listed here.
These are some of them.
So I think it is better to keep "of" here.

My understanding is as follows:

If a sentence is complete, use ":".

The followings are of some major features of Universal Ctags:

If a sentence is not complete, use ";".

Some of major features of Universal Ctags are;

This is the middle of a sentence , "XXX are A, B, C, and D".

I've searched the usage of semicolon, and could not find any good evidences.

@Jonta
Copy link
Contributor Author

Jonta commented Oct 26, 2021

@hirooih "There are more major features than those listed here" is covered by the word "Some"

If y'all want to keep "of", it should be "Some of the major features"

@hirooih
Copy link
Contributor

hirooih commented Oct 26, 2021

@Jonta

I see.
I will accept one of the following which you think better:

Some of the major features of Universal Ctags are;

or

Some of the major features of Universal Ctags are:

Thanks.

@Jonta
Copy link
Contributor Author

Jonta commented Nov 23, 2021

@hirooih Done

Copy link
Contributor

@hirooih hirooih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hirooih
Copy link
Contributor

hirooih commented Nov 23, 2021

@masatake san,
May I merge this?

@masatake
Copy link
Member

@masatake san, May I merge this?

Yes, please.

@hirooih hirooih merged commit f5a54f7 into universal-ctags:master Nov 24, 2021
@masatake
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants