RSpec: rewrite in C language #3202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
==========================================
+ Coverage 84.95% 85.01% +0.05%
==========================================
Files 206 206
Lines 49032 49127 +95
==========================================
+ Hits 41656 41765 +109
+ Misses 7376 7362 -14
Continue to review full report at Codecov.
|
masatake
force-pushed
the
rspec--rewrite
branch
from
f7e5e7c
to
1a0fc02
Compare
|
I make a pull request only for ecd30f1 first of all. |
masatake
force-pushed
the
rspec--rewrite
branch
from
ecd30f1
to
c7b5436
Compare
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
The variable was extern'ed unexpectedly. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
… with the target tag A language can specify whether the main part does automagic-FQ-tag emission or not with requestAutomaticFQTag field of parserDefinition. To access the requestAutomaticFQTag field, the original code calls getInputLanguage(). However, this didn't work expectedly. When a subparser made a tag, it was stored to the corkQueue. The corkQueue was flushed after the subparser run, within the base parser run. As the result requestAutomaticFQTag field of the base parser was referred when calling getInputLanguage(). This changes refers the tag itself to access the requestAutomaticFQTag field instead of calling getInputLanguage(). Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
The new parser fills the scope and end fields. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
rspec--rewrite
branch
from
c7b5436
to
1b09ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.