Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript: allow class methods get and set #3329

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Units/parser-javascript.r/js-get-and-set.d/args.ctags
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
--fields=+K
6 changes: 6 additions & 0 deletions Units/parser-javascript.r/js-get-and-set.d/expected.tags
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
get input.js /^ get() {$/;" method class:obj
log input.js /^ log: ['a', 'b', 'c'],$/;" property class:obj
log input.js /^ log: []$/;" property class:o
o input.js /^var o = {$/;" class
obj input.js /^var obj = {$/;" class
set input.js /^ set(str) {$/;" method class:o
20 changes: 20 additions & 0 deletions Units/parser-javascript.r/js-get-and-set.d/input.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Modified from
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get
var obj = {
log: ['a', 'b', 'c'],
get() {
if (this.log.length == 0) {
return undefined;
}
return this.log[this.log.length - 1];
}
}

// Modified from
// https://developer.mozilla.org/en/docs/JavaScript/Reference/Operators/set
var o = {
set(str) {
this.log[this.log.length] = str;
},
log: []
}
31 changes: 24 additions & 7 deletions parsers/jscript.c
Original file line number Diff line number Diff line change
Expand Up @@ -1618,6 +1618,8 @@ static bool parseMethods (tokenInfo *const token, const tokenInfo *const class,
* container.dirtyTab = {'url': false, 'title':false, 'snapshot':false, '*': false}
* get prop() {}
* set prop(val) {}
* get(...) {}
* set(...) {}
*
* ES6 methods:
* property(...) {}
Expand Down Expand Up @@ -1653,15 +1655,30 @@ static bool parseMethods (tokenInfo *const token, const tokenInfo *const class,

if (isKeyword (token, KEYWORD_async))
readToken (token);
else if (isType(token, TOKEN_KEYWORD) && isKeyword (token, KEYWORD_get))
else if (isType (token, TOKEN_KEYWORD) &&
(isKeyword (token, KEYWORD_get) || isKeyword (token, KEYWORD_set)))
{
is_getter = true;
readToken (token);
}
else if (isType(token, TOKEN_KEYWORD) && isKeyword (token, KEYWORD_set))
{
is_setter = true;
tokenInfo *savedToken = newToken ();
copyToken (savedToken, token, true);
readToken (token);
if (isType(token, TOKEN_OPEN_PAREN))
{
Assert (NextToken == NULL);
NextToken = newToken ();
copyToken (NextToken, token, false); /* save token for next read */
copyToken (token, savedToken, true); /* restore token to process */
token->type = TOKEN_IDENTIFIER; /* process as identifier */
token->keyword = KEYWORD_NONE;
}
else if (isKeyword (savedToken, KEYWORD_get))
{
is_getter = true;
masatake marked this conversation as resolved.
Show resolved Hide resolved
}
else
{
is_setter = true;
masatake marked this conversation as resolved.
Show resolved Hide resolved
}
deleteToken (savedToken);
}

if (! isType (token, TOKEN_KEYWORD) &&
Expand Down