Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ fix invalid test input #3398

Merged

Conversation

masatake
Copy link
Member

See #3388.

@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #3398 (56ab8ff) into master (80ee839) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3398      +/-   ##
==========================================
- Coverage   83.20%   83.19%   -0.01%     
==========================================
  Files         218      218              
  Lines       52428    52428              
==========================================
- Hits        43624    43620       -4     
- Misses       8804     8808       +4     
Impacted Files Coverage Δ
parsers/cxx/cxx_parser_template.c 76.36% <0.00%> (-2.91%) ⬇️
parsers/cxx/cxx_parser_function.c 93.19% <0.00%> (+0.25%) ⬆️
parsers/cxx/cxx_parser_variable.c 91.40% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ee839...56ab8ff. Read the comment docs.

@masatake masatake force-pushed the c++--fix-invalid-test-input branch 2 times, most recently from f4bb64c to d45552a Compare May 31, 2022 21:37
@masatake
Copy link
Member Author

The requested URL returned error: 429 is reported.
Just repeating "re-run failed jobs" doesn't help.

@masatake masatake force-pushed the c++--fix-invalid-test-input branch from d45552a to 7697ad4 Compare June 1, 2022 18:15
@masatake masatake added the C/C++ label Jun 1, 2022
@masatake
Copy link
Member Author

masatake commented Jun 1, 2022

Though d0e1670 is merged to master, The requested URL returned error: 429 is reported. I guess we cannot fix this from our side.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
In universal-ctags#3388, @delsner reported that either C++03 and C++11 doesn't accept
Units/parser-cxx.r/template-nested-triangle-brackets.d/input-2.hpp.

This change makes the input C++11 acceptable.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake force-pushed the c++--fix-invalid-test-input branch from 7697ad4 to 56ab8ff Compare June 6, 2022 04:58
@masatake masatake merged commit 227c65e into universal-ctags:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant