Remove punctuation from SCSS classes & identifers #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can run the test locally with You have to update the following files:
|
Roy-Orbison
force-pushed
the
scss-tags-idents
branch
from
0798a8b
to
3e3acc4
Compare
|
Could you add optlib/scss.c to your commit? |
Roy-Orbison
force-pushed
the
scss-tags-idents
branch
from
3e3acc4
to
32fc3fb
Compare
|
Could you write the background and idea of the change to your commit log? |
Roy-Orbison
force-pushed
the
scss-tags-idents
branch
from
32fc3fb
to
1cad233
Compare
Codecov Report
@@ Coverage Diff @@
## master #3410 +/- ##
=======================================
Coverage 83.19% 83.19%
=======================================
Files 218 218
Lines 52428 52428
=======================================
Hits 43620 43620
Misses 8808 8808
Continue to review full report at Codecov.
|
|
Can I ask two more things?
|
Prevent appended pseudos as well. This should make the tags file output more consistent with other language parsers, where the identifiers are more important than the delimiters that denote their types. This aids completion in existing tools and across languages (like HTML) where the delimiters are not used. Closes universal-ctags#3409
Roy-Orbison
force-pushed
the
scss-tags-idents
branch
from
1cad233
to
15434fe
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3409.