ttcn: add "template" ["(omit)" | "(value)" | "(present)"] #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Could you add a test case? |
|
@akrzyz, could you review this? |
|
Looks fine but please add test case for TemplateRestriction and test there all three possible restrictions. |
Codecov Report
@@ Coverage Diff @@
## master #3456 +/- ##
=======================================
Coverage 83.32% 83.32%
=======================================
Files 219 219
Lines 52750 52752 +2
=======================================
+ Hits 43956 43958 +2
Misses 8794 8794
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks for your review! |
|
See #3466. |
Modern TTCN3 has TemplateRestriction keywords, which improve detection
of invalid template use at compile time. They simply add one of
"(omit)", "(value)", "(present)" after the "template" keyword.
Example:
template (value) ts_FOO_Request(integer bar := 0) :=
{ member := bar };
template (present) tr_FOO_Request(template integer bar := *) :=
{ member := bar };
Before this patch, u-ctags would not tag these two definitons above,
making my work on the Osmocom test suite hard. (See
https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks)
At first I tried to exactly match the three keywords within the braces,
but the token parsing does not support unrolling more than one token. So
if an unmatching token follows after the opening brace, I cannot un-get
the opening brace. The easiest solution, and one that also is tolerant
to keyword typos, is to just accept any braces after "template".
Related: ETSI ES 201 873-1 V4.14.1 § A.1.6.1.3
|
done |
masatake
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern TTCN3 has TemplateRestriction keywords, which improve detection
of invalid template use at compile time. They simply add one of
"(omit)", "(value)", "(present)" after the "template" keyword.
Example:
template (value) ts_FOO_Request(integer bar := 0) :=
{ member := bar };
template (present) tr_FOO_Request(template integer bar := *) :=
{ member := bar };
Before this patch, u-ctags would not tag these two definitons above,
making my work on the Osmocom test suite hard. (See
https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks)
At first I tried to exactly match the three keywords within the braces,
but the token parsing does not support unrolling more than one token. So
if an unmatching token follows after the opening brace, I cannot un-get
the opening brace. The easiest solution, and one that also is tolerant
to keyword typos, is to just accept any braces after "template".
Related: ETSI ES 201 873-1 V4.14.1 § A.1.6.1.3