Verilog: all text macro map to new kindDefinition:define

[my2817]

In some case, readtags return different kind of text macro(define) and parameter is better for me.

[masatake]

You added a new kind. So we should update the parser-specific version number.

Could you merge the following change to your pull request?

diff --git a/man/ctags-lang-verilog.7.rst.in b/man/ctags-lang-verilog.7.rst.in
index 3e2362a98..ad8d36c05 100644
--- a/man/ctags-lang-verilog.7.rst.in
+++ b/man/ctags-lang-verilog.7.rst.in
@@ -195,6 +195,14 @@ KNOWN ISSUES
 
 See https://github.com/universal-ctags/ctags/issues/2674 for more information.
 
+VERSIONS
+--------
+
+Change since "0.0"
+~~~~~~~~~~~~~~~~~~
+
+* New kind ``macro``
+
 SEE ALSO
 --------
 
diff --git a/parsers/verilog.c b/parsers/verilog.c
index 4ba355146..044d1aeab 100644
--- a/parsers/verilog.c
+++ b/parsers/verilog.c
@@ -2086,6 +2086,8 @@ extern parserDefinition* VerilogParser (void)
 {
        static const char *const extensions [] = { "v", NULL };
        parserDefinition* def = parserNew ("Verilog");
+       def->versionCurrent = 1;
+       def->versionAge = 1;
        def->kindTable  = VerilogKinds;
        def->kindCount  = ARRAY_SIZE (VerilogKinds);
        def->fieldTable = VerilogFields;
@@ -2100,6 +2102,8 @@ extern parserDefinition* SystemVerilogParser (void)
 {
        static const char *const extensions [] = { "sv", "svh", "svi", NULL };
        parserDefinition* def = parserNew ("SystemVerilog");
+       def->versionCurrent = 1;
+       def->versionAge = 1;
        def->kindTable  = SystemVerilogKinds;
        def->kindCount  = ARRAY_SIZE (SystemVerilogKinds);
        def->fieldTable = SystemVerilogFields;

One more.
Could you update the list of kinds in man/ctags-lang-verilog.7.rst.in?

Maybe squashing the commits into one is better.

[hirooih]

I also think it is "better" to distinguish a define from constants.
To begin with, a define is not always a constant.

But the question is whether it is worth consuming the precious resource 'd'. I judged that it was not worth it.

Do you have any good reasons (or excuses:-))?

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (7c84355) 82.82% compared to head (6c11e06) 82.82%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3653   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         223      223           
  Lines       54502    54506    +4     
=======================================
+ Hits        45143    45147    +4     
  Misses       9359     9359           

Impacted Files	Coverage Δ
parsers/verilog.c	98.44% <100.00%> (+<0.01%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[masatake]

@my2817, the man is not updated.

[hirooih]

@masatake san,

@my2817, the man is not updated.

I am a little confused.

All CI tests on GitHub had passed, so I merge this PR.
However, distcheck in the CircleCI builds is failing.

---

We have make check and make dist, but there is no make distcheck in .github/workflow/*. I think it was included before.
We should add it again.

[masatake]

The test cases on CircleCI are run for each pull request like #3643.

So the checks were included already. However, it was skipped in this pull request.
I wonder why...

I found some log messages in CircleCI side:

Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.
Please sign out of CircleCI and log back in with your VCS before triggering a new pipeline.

It seems that the actions on CirclCI is recovered now; see the newer pull request: #3654.

[my2817]

@my2817, the man is not updated.

The following patch? We use precious resource "K_DEFINE", but not define a new K_MACRO...
OK, got it. "define" is a new kind to tags file. I will make a new PR, and you can merge or just close it by your judgement.

Thanks.

diff --git a/man/ctags-lang-verilog.7.rst.in b/man/ctags-lang-verilog.7.rst.in
index 3e2362a98..ad8d36c05 100644
--- a/man/ctags-lang-verilog.7.rst.in
+++ b/man/ctags-lang-verilog.7.rst.in
@@ -195,6 +195,14 @@ KNOWN ISSUES
 
 See https://github.com/universal-ctags/ctags/issues/2674 for more information.
 
+VERSIONS
+--------
+
+Change since "0.0"
+~~~~~~~~~~~~~~~~~~
+
+* New kind ``macro``
+
 SEE ALSO
 --------