-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verilog: all text macro map to new kindDefinition:define #3653
Conversation
You added a new kind. So we should update the parser-specific version number. Could you merge the following change to your pull request?
One more. Maybe squashing the commits into one is better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think it is "better" to distinguish a define from constants.
To begin with, a define is not always a constant.
But the question is whether it is worth consuming the precious resource 'd'. I judged that it was not worth it.
Do you have any good reasons (or excuses:-))?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3653 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 223 223
Lines 54502 54506 +4
=======================================
+ Hits 45143 45147 +4
Misses 9359 9359
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@my2817, the man is not updated. |
@masatake san,
I am a little confused. All CI tests on GitHub had passed, so I merge this PR. We have |
The test cases on CircleCI are run for each pull request like #3643. So the checks were included already. However, it was skipped in this pull request. I found some log messages in CircleCI side:
It seems that the actions on CirclCI is recovered now; see the newer pull request: #3654. |
The following patch? We use precious resource "K_DEFINE", but not define a new K_MACRO... Thanks. diff --git a/man/ctags-lang-verilog.7.rst.in b/man/ctags-lang-verilog.7.rst.in
index 3e2362a98..ad8d36c05 100644
--- a/man/ctags-lang-verilog.7.rst.in
+++ b/man/ctags-lang-verilog.7.rst.in
@@ -195,6 +195,14 @@ KNOWN ISSUES
See https://github.com/universal-ctags/ctags/issues/2674 for more information.
+VERSIONS
+--------
+
+Change since "0.0"
+~~~~~~~~~~~~~~~~~~
+
+* New kind ``macro``
+
SEE ALSO
-------- |
In some case, readtags return different kind of text macro(define) and parameter is better for me.