Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powershell: fix string escape issue #3661

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

iaalm
Copy link
Contributor

@iaalm iaalm commented Mar 9, 2023

According to official doc, powershell use ` to escape string and it only works in ".

@masatake
Copy link
Member

masatake commented Mar 9, 2023

Thank you for submitting the pull request.

Please, read https://docs.ctags.io/en/latest/contributions.html#squashing-commits .

I don't want to merge your try-and-error commit sequence.
If you fixed more than two different issues, don't unify the commits into one.
However, modifying-something-then-revert-parts-of-them commits can be unified into one.

Please, read https://docs.ctags.io/en/latest/contributions.html#title-of-commit-log-and-pull-request

Maybe "Powershell: " is the suitable prefix.

According to official doc, powershell use ` to escape string and it only works in ".

Thank you. This is important information for the current reviewers and future reviewers.
Please, put it in the commit log.

Thank you.

@kumarstack55 Can I ask you to look into this pull request?

@iaalm
Copy link
Contributor Author

iaalm commented Mar 9, 2023

OK! Let me update the PR.

@iaalm iaalm changed the title Fix PowerShell string escape and add *swp to .gitignore Powershell: fix string escape issue Mar 9, 2023
Powershell use ` instead of \ to escape string. Current implement
ignores all code after something like "\".
ref: https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_special_characters?view=powershell-7.3
@masatake
Copy link
Member

masatake commented Mar 9, 2023

Thank you.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (bd568be) 82.83% compared to head (bca2e86) 82.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3661   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files         223      223           
  Lines       54508    54508           
=======================================
  Hits        45149    45149           
  Misses       9359     9359           
Impacted Files Coverage Δ
parsers/powershell.c 93.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iaalm
Copy link
Contributor Author

iaalm commented Mar 10, 2023

@kumarstack55 could you help reviewing this PR?

@masatake masatake merged commit ac7a805 into universal-ctags:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants