SQL: handle "DATABASE" and "SCHEMA" keywords specially only when they come after "CREATE" #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… come after "CREATE" Close universal-ctags#3636. The parser emitted the warning, "ignoring null tag in ...", when reading "alter database ..." from an input stream. The unexpected warning was originally reported in https://twitter.com/fujii_masao/status/1619860698997329920. This fix is inspired by the comment (universal-ctags#3636 (comment)) submitted by Fujii Masao (@MasaoFujii). Fujii Masao illustrated the way for the correct fix: Probably it's valid to ignore ALTER statement in PostgreSQL, but what about other DBMS? I'm afraid that ALTER statement is not in SQL standard and other DBMS may handle the keyword "ALTER" differently from PostgreSQL. The cause of the issue seems that the keywords "DATABASE" and "SCHEMA" are processed even if they don't follow "CREATE". That is, the following SQL statements can cause ctags to emit warnings. ALTER DATABASE ... SELECT * FROM pg_locks WHERE database = ... To fix the issue, I think that the keywords "DATABASE" and "SCHEMA" should be processed only just after the keyword "CREATE" is processed. How about something like the following change?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3674 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 223 223
Lines 54561 54566 +5
=======================================
+ Hits 45219 45224 +5
Misses 9342 9342
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3636.
The parser emitted the warning, "ignoring null tag in ...", when reading "alter database ..." from an input stream. The unexpected warning was originally reported in
https://twitter.com/fujii_masao/status/1619860698997329920.
This fix is inspired by the comment
(#3636 (comment)) submitted by Fujii Masao (@MasaoFujii).
Fujii Masao illustrated the way for the correct fix: