Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

main: Don't strdup the inputFileName when storing a tag to the corkQueue #3682

Merged
merged 1 commit into from
Mar 31, 2023
Merged

main: Don't strdup the inputFileName when storing a tag to the corkQueue #3682

merged 1 commit into from
Mar 31, 2023

Commits on Mar 28, 2023

  1. main: Don't strdup the inputFileName when storing a tag to the corkQueue 

    When storing a tag entry to the corkQueue, the most of members
of the tag entry are duplicated for isolating the the stored tag
entry from the original parsing context.

In the most of all cases, we can expect all tag entries in the
corkQueue has the same value as inputFileName member. Strdup'ing
the value is waste of memory resource especially when the input
file name is long.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
    @masatake
    masatake committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    9fd7417 View commit details
    Browse the repository at this point in the history