Terraform (HCL) (*.tf): new parser #3683
Conversation
There was a problem hiding this comment.
Could you add "args.ctags" file with contents:
--sort=no
Sorted tags output is hard to compare with the input.
optlib/terraform.ctags
Outdated
| --regex-terraform=/^[[:space:]]*provider[[:space:]]*"([^"]*)"/\1/p,Provider/ | ||
| --regex-terraform=/^[[:space:]]*module[[:space:]]*"([^"]*)"/\1/m,Module/ | ||
| --regex-terraform=/^[[:space:]]*output[[:space:]]*"([^"]*)"/\1/o,Output/ | ||
| --regex-terraform=/^resource[[:space:]]"([^"]+)"[[:space:]]"([^"]+)"/\2/r,Resource/ |
There was a problem hiding this comment.
You use both kind letter and kind long name in "r,Resource".
However, r is already defined with --kinddef-terraform. So you should use only 'r' here.
--regex-terraform=/^resource[[:space:]]"([^"]+)"[[:space:]]"([^"]+)"/\2/r/
optlib/terraform.ctags
Outdated
| --regex-tf=/^[[:space:]]*module[[:space:]]*"([^"]*)"/\1/m,Module/ | ||
| --regex-tf=/^[[:space:]]*output[[:space:]]*"([^"]*)"/\1/o,Output/ | ||
| --regex-tf=/^([a-z0-9_]+)[[:space:]]*=/\1/f,TFVar/ | ||
| --langdef=terraform |
There was a problem hiding this comment.
Terraform or TerraForm is better.
There was a problem hiding this comment.
You are right. It should be Terraform.
|
Looks good for me. @Haggus thank you for adding the test cases. They were really what I needed. I would like to squash these into one. I would like to squash into one commit. The Author must be Antony Southworth. So your named will be put to the commit like: Is this acceptable? |
Sounds good to me 👍 |
|
Ok, I will take over this. |
|
@masatake One more thing. Windows build doesn't pass. I think entries in |
|
It's all green, good to go! |
|
See #3684. |
|
Closed via #3684. |
Add support for Terraform (HCL) files.
Continuation of #2952