-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoit: Drop $ from variable names #3697
Conversation
At least PHP, which also declares variables using $, such as $x = 5; outputs pure variable name without the $ prefix and this patch unifies this behavior.
Autocompletion doesn't work for variables in Geany because of this, see geany/geany#3460. We could add a workaround if having the |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3697 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 226 226
Lines 54750 54752 +2
=======================================
+ Hits 45349 45351 +2
Misses 9401 9401
☔ View full report in Codecov by Sentry. |
Thank you. This makes sense. However, the impact is not small; there can be a client tool that expects names start from Since version 6.0.0, I introduced per-parser versioning. This is a good time to utilize it.
Though your change doesn't match the criteria I wrote as the comment, obviously this is the Could you add the following change to your commit?
I will add a man page for the parser to explain this change, like https://docs.ctags.io/en/latest/man/ctags-lang-kconfig.7.html, later. |
I'll take over this. |
OK, great. |
The change in the last commit for the parser is not small. So I increment the current, and set 0 to age. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Thank you. |
This patch has been upstreamed in universal-ctags/ctags#3697
This patch has been upstreamed in universal-ctags/ctags#3697
This patch has been upstreamed in universal-ctags/ctags#3697
At least PHP, which also declares variables using
$
, such asoutputs pure variable name without the
$
prefix and this patch unifies this behavior.