Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D: set template members parent name #3707

Merged
merged 1 commit into from
May 4, 2023

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented May 1, 2023

From Geany.
So:

  • Template has children TemplateAlias and new symbol memb.
  • new template each has children tmethod and child.

Add templates.d test, move 5 template declarations here from simple.d test. Commented out templates AT, ET have also been moved.

I'm not sure if the build system needs updating for the new test, please let me know.

@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (4622e54) 82.96% compared to head (690d8b3) 82.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3707      +/-   ##
==========================================
+ Coverage   82.96%   82.99%   +0.03%     
==========================================
  Files         226      226              
  Lines       54962    54967       +5     
==========================================
+ Hits        45598    45620      +22     
+ Misses       9364     9347      -17     
Impacted Files Coverage Δ
parsers/c-based.c 82.14% <100.00%> (+1.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masatake
Copy link
Member

masatake commented May 1, 2023

I'm not sure if the build system needs updating for the new test, please let me know.

No, you don't have to update any build scripts.

Non-sorted output is easier for me to compare expected.tags and the actual output (FILTERED.out). So could you add Units/parser-d.r/templates.d/args.ctags with the following content:

--sort=no

. See https://docs.ctags.io/en/latest/testing-parser.html#how-to-write-a-test-case about args.ctags file.

You may have to update the expected.tags. misc/review script may be helpful.

$ echo "--sort=no" > Units/parser-d.r/templates.d/args.ctags
$ make units
...
$ bash misc/review
[jet@living]~/var/ctags-github% misc/review 
1) <a>ccept
2) <s>kip (or <n>)
3) <S>hell
4) <d>iff
5) show args.<c>tags
6) show <i>nput
7) <e>xpected tags
8) <q>uit
[1/2 [ Units/parser-d.r/templates.d ]]? a
...[Y/n]: Y
...[Y/n]: Y

Feel free to do "git commit --amend; git push --force".

Add templates.d test, move template declarations here from simple.d
test.
@ntrel
Copy link
Contributor Author

ntrel commented May 2, 2023

--sort=no

Great!

You may have to update the expected.tags. misc/review script may be helpful

That's useful, thanks.

@masatake masatake merged commit 20c45ce into universal-ctags:master May 4, 2023
@ntrel ntrel deleted the d-template branch May 9, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants