-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
D: fix parsing parameter with pointer #3715
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3715 +/- ##
==========================================
+ Coverage 82.96% 83.00% +0.04%
==========================================
Files 226 226
Lines 54969 54969
==========================================
+ Hits 45606 45629 +23
+ Misses 9363 9340 -23
☔ View full report in Codecov by Sentry. |
Units/parser-d.r/simple.d.d/input.d
Outdated
@@ -73,7 +73,7 @@ Object obj; | |||
|
|||
const(int)* type_con; | |||
immutable(int)* type_imm; | |||
inout(int)* f_inout(inout Object); // FIXME | |||
inout(int)* f_inout(inout(int)* p) { return p; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of replacing this new f_input
with
inout(int)* f_inout(inout Object);
,
could you add this new one as g_inout
or something like:
inout(int)* f_inout(inout Object);
inout(int)* g_inout(inout(int)* p) { return p; }
?
Here I assume, with this new change, ctags can extract both f_input
and g_input
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason D prototypes are not generating tags:
- Interface.bar is missing
- attr_post is missing
The weird thing is that in my branch of Geany there are tags for prototypes, and I don't think c-based.c has any changes that cause it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored inout prototype.
Thank you for updating. |
Keep separate inout prototype
Thank you! |
This just removes the remnants of code for fallback C parsing.
identifierCount
is never changed anywhere.Now the test for
inout(T)
works.