Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript : mark xtag bit for implicitClass xtags #3717

Merged
merged 3 commits into from
May 12, 2023
Merged

GDScript : mark xtag bit for implicitClass xtags #3717

merged 3 commits into from
May 12, 2023

Commits on May 12, 2023

  1. GDScript,cosmetic: adjust whitespaces 

    Signed-off-by: Masatake YAMATO <yamato@redhat.com>
    @masatake
    masatake committed May 12, 2023
    Configuration menu
    Copy the full SHA
    82bbe47 View commit details
    Browse the repository at this point in the history

  2. main: use isTagExtra() to decided whether "extras:" is emitable or not 

    The original isExtrasFieldAvailable() had a bug.
It verifies only (tag->extraDynamic != NULL) to detect
a tag has dynamic extras or not. With this logic,
isExtrasFieldAvailable() returns true even when all bits
in extraDynamic are 0. The condition should be

  (tag->extraDynamic != NULL) && anyBitIsSet (tag->extraDynamic)

.

isTagExtra() uses a condition.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
    @masatake
    masatake committed May 12, 2023
    Configuration menu
    Copy the full SHA
    2637b00 View commit details
    Browse the repository at this point in the history

  3. GDScript: mark xtag bit for implicitClass xtags 

    Signed-off-by: Masatake YAMATO <yamato@redhat.com>
    @masatake
    masatake committed May 12, 2023
    Configuration menu
    Copy the full SHA
    af3b00d View commit details
    Browse the repository at this point in the history