colprint: Fix column width truncation #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very theoretical though, but pleases -Wconversion.
masatake
approved these changes
May 15, 2023
|
Should we specify -Wconversion in our build scripts? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3725 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 226 226
Lines 55006 55009 +3
=======================================
+ Hits 45652 45655 +3
Misses 9354 9354
☔ View full report in Codecov by Sentry. |
|
Not yet I think, there are way too may warnings with it for the moment, and I'm afraid of less skilled C developers trying to "fix them", as I've seen my share of wrong fixes with those, mostly because it's often a bit tricky to fix property yet easy to think a partial or incorrect fix is ok.
So I'd leave it for now for people that actually know enough to enable it and carefully check each one.
Le 15 mai 2023 20:03:38 GMT+02:00, Masatake YAMATO ***@***.***> a écrit :
…Should we specify -Wconversion in our build scripts?
--
Reply to this email directly or view it on GitHub:
#3725 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very theoretical though, but pleases -Wconversion.