lregex: optimize substitute() #3728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
substitute was one of the bottle neck. It called strlen before memcpy. We can remove the strlen invocation safely. The original code: $ xargs cat < /tmp/list > /dev/null; time ./ctags -L - < /tmp/list ./ctags -L - < /tmp/list 97.39s user 4.72s system 97% cpu 1:45.09 total With this change: $ xargs cat < /tmp/list > /dev/null; time ./ctags -L - < /tmp/list ./ctags -L - < /tmp/list 87.24s user 4.68s system 97% cpu 1:34.28 total About 10% faster! Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3728 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 226 226
Lines 55006 55009 +3
=======================================
+ Hits 45652 45655 +3
Misses 9354 9354
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substitute was one of the bottle neck.
It called strlen before memcpy.
We can remove the strlen invocation safely.
The original code:
$ xargs cat < /tmp/list > /dev/null; time ./ctags -L - < /tmp/list
./ctags -L - < /tmp/list 97.39s user 4.72s system 97% cpu 1:45.09 total
With this change:
$ xargs cat < /tmp/list > /dev/null; time ./ctags -L - < /tmp/list
./ctags -L - < /tmp/list 87.24s user 4.68s system 97% cpu 1:34.28 total
About 10% faster!