Ruby: don't make a scope for "Class.new..." with no block #3733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3733 +/- ##
=======================================
Coverage 83.04% 83.04%
=======================================
Files 227 227
Lines 55175 55184 +9
=======================================
+ Hits 45819 45828 +9
Misses 9356 9356
☔ View full report in Codecov by Sentry. |
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
D = Class.new()
def bar()
...
end
The original code filled the scope field of "bar" with the anonymous
tag for "Class.new". This was wrong; bar is not a part of D.
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…th self. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
ruby--class-new-with-no-block
branch
from
532a232
to
692a024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.