Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact github/workflows/tagging.yml #3755

Merged

Conversation

leleliu008
Copy link
Member

@leleliu008 leleliu008 commented Jun 27, 2023

  1. use fetch-depth: 0 with actions/checkout@v3, beacuse default is fetch-depth: 1 which means only one commit is fetched and no tags and branches are fetched.
    close Last tags are identical? #3754

  2. It looks like someone tries to use USER_NAME and USER_EMAIL to configure git user.name and user.email, this didn't take effect. so I add following:

git config user.name  'Universal-ctags CI'
git config user.email 'Universal-ctags@users.noreply.github.com'
  1. I removed some unsed code in this file.

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6b4d32e) 83.01% compared to head (065350f) 83.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3755   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files         227      227           
  Lines       55128    55128           
=======================================
  Hits        45766    45766           
  Misses       9362     9362           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

1. use `fetch-depth: 0` with `actions/checkout@v3`, beacuse default is
   `fetch-depth: 1` which means only one commit is fetched and no tags
   and branches are fetched.

2. It looks like someone tries to use `USER_NAME` and `USER_EMAIL` to configure git `user.name` and `user.email`, this didn't take effect. so I add following:

```bash
git config user.name  'Universal-ctags CI'
git config user.email 'Universal-ctags@users.noreply.github.com'
```

3. I removed some unsed code in this file.

Signed-off-by: leleliu008 <leleliu008@gmail.com>
@masatake
Copy link
Member

masatake commented Jun 27, 2023

Thank you. I understand why misc/git-tag-maybe.sh script has not worked.

@leleliu008 leleliu008 merged commit 2058211 into universal-ctags:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last tags are identical?
2 participants