refact github/workflows/tagging.yml #3755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3755 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 227 227
Lines 55128 55128
=======================================
Hits 45766 45766
Misses 9362 9362 ☔ View full report in Codecov by Sentry. |
1. use `fetch-depth: 0` with `actions/checkout@v3`, beacuse default is `fetch-depth: 1` which means only one commit is fetched and no tags and branches are fetched. 2. It looks like someone tries to use `USER_NAME` and `USER_EMAIL` to configure git `user.name` and `user.email`, this didn't take effect. so I add following: ```bash git config user.name 'Universal-ctags CI' git config user.email 'Universal-ctags@users.noreply.github.com' ``` 3. I removed some unsed code in this file. Signed-off-by: leleliu008 <leleliu008@gmail.com>
leleliu008
force-pushed
the
set-git-user-name-and-email
branch
from
252582c
to
065350f
Compare
masatake
approved these changes
Jun 27, 2023
|
Thank you. I understand why misc/git-tag-maybe.sh script has not worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
fetch-depth: 0withactions/checkout@v3, beacuse default isfetch-depth: 1which means only one commit is fetched and no tags and branches are fetched.close Last tags are identical? #3754
It looks like someone tries to use
USER_NAMEandUSER_EMAILto configure gituser.nameanduser.email, this didn't take effect. so I add following: