Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: make --version and --help options work even if a broken .ctags is given #3756

Merged

Conversation

masatake
Copy link
Member

@masatake masatake commented Jul 3, 2023

Here "broken" means .ctags redefines an existing language with --langdef option like --langdef=C.

Close #2935.

@masatake masatake added this to the 6.1 milestone Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9b421f1) 83.01% compared to head (30c420a) 83.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3756   +/-   ##
=======================================
  Coverage   83.01%   83.02%           
=======================================
  Files         227      227           
  Lines       55128    55134    +6     
=======================================
+ Hits        45766    45773    +7     
+ Misses       9362     9361    -1     
Impacted Files Coverage Δ
main/options.c 83.98% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masatake masatake force-pushed the eval--help-and-version-earlier branch from c33e61f to eca129d Compare July 3, 2023 09:45
…is given

Here "broken" means .ctags redefines an existing language with --langdef
option like --langdef=C.

Close universal-ctags#2935.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake force-pushed the eval--help-and-version-earlier branch from eca129d to 30c420a Compare July 4, 2023 14:46
@masatake masatake merged commit 88ad24f into universal-ctags:master Jul 4, 2023
38 checks passed
@k-takata k-takata changed the title main: make --verison and --help options work even if a broken .ctags is given main: make --version and --help options work even if a broken .ctags is given Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

main: ctags option processing fails if "Language already defined", including ctags --help
1 participant