main: reserve errno in external sorting #3779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why use system(3) to execute the external command? for portable reason? As we all known system(3) is dangerous and have limitations. References: |
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
This change fixes that ctags reports the following strange error message: $ /usr/bin/ctags --quiet --options=NONE -o - main/*.c | no-such-command zsh: no-such-command: command not found... ctags: cannot sort tag file : Success With this change, ctags reports: ./ctags --quiet --options=NONE -o - main/*.c | no-such-command zsh: no-such-command: command not found... ctags: cannot sort tag file Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
reserve-errno-in-external-sorting
branch
from
51334d4
to
a491e8e
Compare
|
exuberant-ctags used system(3). |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3779 +/- ##
==========================================
- Coverage 83.04% 83.04% -0.01%
==========================================
Files 227 227
Lines 55192 55199 +7
==========================================
+ Hits 45836 45839 +3
- Misses 9356 9360 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes that ctags reports the following strange error message:
Success?
With this change, ctags reports: