Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LdScript: reject " and ' as a part of an identifier #3782

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Units/parser-ldscript.r/cpp-out-of-band-chars.d/README
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This is a crash test.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0"x"
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0'x'
1 change: 1 addition & 0 deletions Units/parser-ldscript.r/cpp-out-of-band-chars.d/input.lds
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/* Nothing here */
3 changes: 2 additions & 1 deletion parsers/ldscript.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,8 @@ static int makeLdScriptTagMaybe (tagEntryInfo *const e, tokenInfo *const token,
}

#define isIdentifierChar(c) \
(cppIsalnum (c) || (c) == '_' || (c) == '.' || (c) == '-' || (c) >= 0x80)
(cppIsalnum (c) || (c) == '_' || (c) == '.' || (c) == '-' \
|| (((c) >= 0x80) && ((c) <= 0xff)))

static int readPrefixedToken (tokenInfo *const token, int type)
{
Expand Down
Loading