-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forth: new parser #3812
Forth: new parser #3812
Conversation
Run |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3812 +/- ##
==========================================
- Coverage 85.06% 85.03% -0.04%
==========================================
Files 226 227 +1
Lines 53857 53889 +32
==========================================
+ Hits 45816 45824 +8
- Misses 8041 8065 +24
☔ View full report in Codecov by Sentry. |
parsers/forth.c
Outdated
@@ -0,0 +1,76 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this file anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I understand. But couldn't it be possible to skip it anyway? Geany told me they wanted it to be pushed upstream before integrating it into their code, and on the other hand they can't handle the .ctags / optlib tags...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See geany/geany#3557 .
The .ctags is translated to C. So technically, it is possible to integrate the .ctags based Forth parser into Geany.
Let's see how Geany people say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farvardin we got a positive answer from Geany developers introducing an optlib-based parser to Geany.
Could you remove parsers/forth.c ?
If we recognize the optlib-based implementation is not enough, you can open a pull request implementing the parser with crafted-C-code in the future. We can re-implement the parser safely because we have the test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masatake ok, I've done it. There was a conflict merge, I hope I haven't deleted some of your code, but it seems fine from my side
Do you know any large (open) source code bases written in Forth. I would like to add them to https://github.com/universal-ctags/codebase. |
I push two commits to your branch. |
good idea. https://git.savannah.gnu.org/cgit/gforth.git/tree/ some files are quite small, but others might be good candidates |
The repositories are suggested by @farvardin in universal-ctags/ctags#3812 (comment) Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Added Forth based source trees to the our codebase. |
You removed |
Thank you. |
@masatake thank you for your help and for this inclusion in ctags! |
see #3810