buildsys: improve cross-build for freebsd and openbsd #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3860 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 228 228
Lines 53901 53901
=======================================
Hits 45832 45832
Misses 8069 8069 ☔ View full report in Codecov by Sentry. |
on FreeBSD and OpenBSD, the most 3rd-party libs are installed in /usr/local/lib directory, we need to manully add -L/usr/local/lib to LDFLAGS only when do native build. Signed-off-by: leleliu008 <leleliu008@gmail.com>
leleliu008
force-pushed
the
fix-freebsd-openbsd-LDFLAGS
branch
from
d90e838
to
afcf86c
Compare
masatake
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on
FreeBSDandOpenBSD, the most 3rd-party libs are installed in/usr/local/libdirectory, we need to manully add-L/usr/local/libtoLDFLAGSonly when do native build.