Vera: revise the dataflow of cppGetc -> vStringPut #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebugging debugPutc() in the main part uses STRING_SYMBOL and CHAR_SYMBOL. These two symbols are CPreProcessor specific. So, conceptually debugPutc should be a part of CPreProcessor. This change does two things: copying debugPutc() to cppDebugPutc(), and simplyfing the origial debugPutc(). The new debugPutc() doesn't use STRING_SYMBOL and CHAR_SYMBOL at all. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
…cessor.h enum eCharacters including STRING_SYMBOL and CHAR_SYMBOL are CPreProcessor specific. Therefore they should be parts of CPreProcessor. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Except STRING_SYMBOL and CHAR_SYMBOL, the character names are used only in CPreProcessor. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Close universal-ctags#3771. Did the same as universal-ctags#3796. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3886 +/- ##
==========================================
- Coverage 85.33% 85.32% -0.01%
==========================================
Files 231 231
Lines 55728 55732 +4
==========================================
+ Hits 47553 47555 +2
- Misses 8175 8177 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3771.